Repository navigation
Validate declared send scheduling and transaction requirements - #184
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Review of #184: validate declared send scheduling and transaction requirementsI read the diff in full, plus the surrounding Overall: the design is sound, and I found nothing blocking.
Non-blocking suggestions
|
|
Disposition of Claude's current-head review: no blocking findings. The complete validation report has now replaced the initial creation body. Per-message cost: two transaction enum checks and scheduling bool checks, plus a cached EF configuration assignment, 0 B added; no loop, lock, await, copy or capability discovery.
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbe5098d93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
Review of PR 184I read the full diff against AGENTS.md and the design record. I found nothing that should block merge. I did not build or run the tests; the PR's reported pass counts are the only test evidence I have. What I checked
Non-blocking notes
|
|
Disposition of Claude's review of 59dfdd6: CLEAR; no blocking findings.
|
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Promotion audit for head 59dfdd6: Claude CLEAR and Codex completed without findings both name this head. All review bodies, inline comments, conversation comments and the resolved thread were checked; no later reviewer reply remains undispositioned. Reverified all 324 files in the current-head archive against the recorded lengths and SHA-256 hashes, plus all 1,387 files in the historical dbe5098 archive. The 30 original files still present also match; worktree cleanup removed the other originals, but their archived copies remain intact. Inventory hashes match the PR description. Durable locations remain C:/git/Relayer-evidence/pr-184/59dfdd6fb973479d4a9d87229f9f8a64f93d5d13/ and C:/git/Relayer-evidence/pr-184/dbe5098d93248e522fbc4de89f21efd0e896593f/ with local PR lifecycle retention. No validation was rerun or newly claimed during this promotion audit. |
Send routes can now declare
RequiredDeliveryDelayand an explicitSendTransactionRequirementon existingSendRouteOptions. Startup validates exact native delay boundaries or an executable durable fallback before consumers start. The existing capability cache is reused; composition resolves scoped outbox capabilities once and retains only immutable values.Review fix 59dfdd6 caches EF default scheduling capabilities per immutable options version. Sender delivery scopes copy two booleans without constructing SQL-bearing configuration or validating a new options snapshot. Configuration reload updates newly resolved enlistments; existing enlistments keep their defaults, and the selected DbContext's settings still govern scheduling before buffering. The cache retains no scoped services.
Validation on current head 59dfdd6 (Windows with Docker Desktop):
npm ciandnpm run buildpass. The unchanged 27 dependency audit findings remain tracked in Address documentation dependency audit vulnerabilities #101.[MemoryDiagnoser]scope-resolution benchmark and theperformancelabel. Dry and default runs pass. Allocations fall from 72.35 KB to 3.69 KB per scope, including existing DI/enlistment allocations. These are diagnostic local results; concurrent PostgreSQL tests affected latency variance, so they are not a throughput gate.Per-message send checks remain constant-time, 0 B added. Default discovery uses an options-monitor cache lookup, a volatile snapshot read and a reference comparison per new enlistment scope; SQL construction, options validation and worker matching are amortized per options version. Active-context checks remain unchanged.
Current evidence:
C:/git/Relayer-evidence/pr-184/59dfdd6fb973479d4a9d87229f9f8a64f93d5d13/(local PR lifecycle retention). Verified 324 copied files against original length and SHA-256, including raw logs, final test reports/binaries, native executable, benchmark reports/binaries and exact source ZIP. Inventory SHA-256:21C7B9019F3CC4D2866F08A8BAE78FCB6D055F235EC8901D3CB98EB6230BA00D. No generated evidence is committed.Earlier validation on dbe5098: 964 full-solution tests passed before two final startup tests; final core suite then passed 553 tests and focused capability/sender suite passed 108. This is historical validation, not a full-solution run of the current head. Its separately verified archive remains at
C:/git/Relayer-evidence/pr-184/dbe5098d93248e522fbc4de89f21efd0e896593f/with inventory SHA-25692CCB6B2027315697A8993C4EA196090D2F8AF092074833B1FF42304A265DDE2.Closes #7